-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/huber chiller #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renereimann
wants to merge
30
commits into
main
Choose a base branch
from
feature/huber_chiller
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mand entity that we can use e.g. to degas our pressure gauges
…s already defined in FormatEntity in init and on_get function.
…e to apply the asteval function to the dict value not the dict itself.
…ormatEntityAsteval into AstevalFormatEntity, checking of input at constructor, improving doc strings
…We assemble and the command at each get / set and disensemble / format the response corresponding to the datatype defined by pfeiffer.
…nd thus split in a general extraction and the entity specific conversion
no message
CommandEntity and FormatEntity with asteval supports
…d parts of the disensembled message. Nicer formarting of long dict.
Pfeiffer Endpoint: Implementation of Pfeiffer telegram protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement yet another company specific service and endpoint.
For the chiller from Huber there is a set of three commands however one of the commands controls several values (get and set).
Therefore we implement the protocol from Huber.
The tool works nicely with our chiller and we can read: