fix(base64): disable base64 utils injections by default#14
Open
sabaturgay wants to merge 3 commits intoprisma:mainfrom
Open
fix(base64): disable base64 utils injections by default#14sabaturgay wants to merge 3 commits intoprisma:mainfrom
sabaturgay wants to merge 3 commits intoprisma:mainfrom
Conversation
aqrln
reviewed
Feb 24, 2025
| @@ -1,9 +1,5 @@ | |||
| import 'react-native-url-polyfill/auto'; | |||
| import { NativeModules } from 'react-native'; | |||
| import { atob, btoa } from 'react-native-quick-base64'; | |||
Member
There was a problem hiding this comment.
Could we also remove the dependency if it's not used anymore?
Author
There was a problem hiding this comment.
just updated the PR and removed all refs to react-native-quick-base64
aqrln
approved these changes
Feb 24, 2025
Member
|
@sabaturgay looks like there's a merge conflict in README.md, could you rebase and fix it? |
Author
|
@aqrln thanks a lot for your help with this PR! I think the changes are ready to be merged. What do you think? |
aqrln
approved these changes
Mar 6, 2025
Member
|
@sabaturgay it looks like the lockfile is not up-to-date: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #13