Conversation
The string.rstrip method does not exist in Py3K.
Py3K does not automatically encode unicode into its bytes repr so the len() call used for calculating an offset in the header is wrong. This patch does a simple py3k duck test and calls str.encode() when appropriate.
For Py3K we can use tokenize.open to read source code files in the preferred style (pep 263). Trap any exception during source code parsing and continue on instead of aborting the process. For large file lists that include the python standard library (and its tests) there are unavoidable exceptions of a variety of sources and we don't want to break the entire DB generation when this happens.
Owner
|
@mayfield, I think the patches look good, but I have to do some work to make sure the unit tests are running properly on 2.6.9, 2.7.10, and 3.4.3 before I take this in. Can you also add unit tests for your changes? |
piccobit
pushed a commit
to piccobit/pycscope
that referenced
this pull request
Feb 24, 2017
Closed
lonetwin
pushed a commit
to lonetwin/pycscope
that referenced
this pull request
Apr 4, 2017
lonetwin
pushed a commit
to lonetwin/pycscope
that referenced
this pull request
May 2, 2017
lonetwin
pushed a commit
to lonetwin/pycscope
that referenced
this pull request
May 2, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The string.rstrip method does not exist in Py3K.
EDIT: And unicode support for Py3k.
EDIT2: Generally this just makes Py3k support better. :)