Open
Conversation
Contributor
|
my preference would be to keep CRD structured rather then a flat list of parameters, similar to other options: tracing:
datadog:
address: xxxxxxxor tracing:
jaeger:
collectorEndpoint: xxxxand
imagine in future we would have OTEL export for example that may have a whole bunch of parameters and it would be nice to group them somewhere under tracing:
otel:this spec is used to auto-generate reference documentation with topmost level keys becoming sections: https://www.pomerium.com/docs/deploying/k8s/reference |
|
Is it still not possible to configure tracing with Pomerium using this? It seems like setting it via environment variables doesn't work either (i.e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the tracing configs in the Pomerium CRD
Checklist
improvement/bug/ etc)