assoc error in request ex-info data#25
Open
tiensonqin wants to merge 5 commits intoplumatic:masterfrom
Open
Conversation
Member
|
Thanks for the PR. I understand the use case, but I think we explicitly avoided putting :error in there since it was causing other problems in default use cases (I believe errors aren't currently serializable). Rather than this, what do you think about allowing the user to pass a custom error handler that takes {:schema schema
:data data
:context context
:error error}into the middleware, where the error handler is defaulted to the current behavior |
Author
|
Yeah, I agree with u, custom error handler is going to be ok. |
Conflicts: project.clj src/fnhouse/middleware.clj src/fnhouse/schemas.clj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need parse the error to show readable errors to end user,
for example: