Some changes to make things work on Linux#13
Open
jfinkhaeuser wants to merge 4 commits intopixeljetstream:mainfrom
Open
Some changes to make things work on Linux#13jfinkhaeuser wants to merge 4 commits intopixeljetstream:mainfrom
jfinkhaeuser wants to merge 4 commits intopixeljetstream:mainfrom
Conversation
- Add <cfloat> for FLT_* constants It could've been <string.h> and <float.h>, but if this is C++, it might as well be the C++ headers.
- A few headers were missing, or the C headers were used. - Add a few std:: prefixes to functions from C++/C compatibility headers - When trying to resolve parts, ensure / directory separators are used when necessary. Without that last change, loading a model won't find sub-parts in the "s" subdirectory of the library. This does nothing on Windows, and on POSIX somewhat simplistically assumes that whenever a backslash is found in a "file name", it should really be a slash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like this project! Unfortunately, it didn't build on Linux, but the changes necessary are relatively small.
I don't know if you like those particular choices (e.g. using C++ <c*> headers instead of C <*.h> ones, with the std:: implications). Happy to adjust if necessary.
This is tested with:
gcc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0Ubuntu clang version 22.0.0 (++20260105081943+212527c00ba6-1~exp1~20260105082109.1379)So far only on x86_64; I don't really need more at this point.