mxml_load_data: do not dereference NULL on mxml_error()#4
Open
hmh wants to merge 1 commit intopivasoftware:masterfrom
Open
mxml_load_data: do not dereference NULL on mxml_error()#4hmh wants to merge 1 commit intopivasoftware:masterfrom
hmh wants to merge 1 commit intopivasoftware:masterfrom
Conversation
Clean up missing guards in mxml_error() calls that have been copy-and-pasted everywhere. Not deduping the copy-paste, as it is code-smell that shows this library would benefit from several cleanups and maybe refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up missing guards in mxml_error() calls that have been copy-and-pasted everywhere.
Not deduping the copy-paste, as it is code-smell that shows this library would benefit from several cleanups and maybe refactoring.
Fixes: pivasoftware/microxml #2