Skip to content

Remove stale keychain entries#155

Merged
wesleymccollam merged 9 commits intomainfrom
remove-stale-keychain-entries
Feb 9, 2026
Merged

Remove stale keychain entries#155
wesleymccollam merged 9 commits intomainfrom
remove-stale-keychain-entries

Conversation

@wesleymccollam
Copy link
Contributor

Change Description

Change Characteristics

  • This PR contains beta functionality
  • This PR requires introduction of breaking changes

Checklist

All full (or complete) PRs that need review prior to merge should have the following box checked.

If contributing a partial or incomplete change (expecting the development team to complete the remaining work) please leave the box unchecked

  • Check to confirm: I have performed a review of my PR against the PR checklist and confirm that:
    • Changes have proper unit and acceptance test coverage (including regression tests)
    • Impacted command, parameter and flag descriptions have been reviewed and updated
    • Impacted command examples have been reviewed and updated
    • Impacted documentation files have been reviewed and updated
    • Does not introduce breaking changes to commands, parameters or flags (unless required to do so)
    • I am aware that changes to generated code may not be merged

Required SDK Upgrades

https://github.com/pingidentity/pingone-go-client v0.7.0

Testing

This PR has been tested with:

  • Unit tests (please paste commands and results below)
  • Acceptance tests (please paste commands and results below)
  • End-to-end tests (please paste the link to the actions workflow runs)
  • Not applicable (no evidences needed)

Shell Command(s)

go test -v -run TestClearToken_UsesClearAllTokens ./internal/commands/auth/... -count=1

Testing Results

Expand Results
=== RUN   TestClearToken_UsesClearAllTokens
--- PASS: TestClearToken_UsesClearAllTokens (0.00s)
PASS
ok  	github.com/pingidentity/pingcli/internal/commands/auth	0.407s

@wesleymccollam wesleymccollam requested a review from a team as a code owner February 6, 2026 21:47
}
}

credentialsDir := filepath.Join(homeDir, ".pingcli", "credentials")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use constants for these strings across the project so that they are easier to maintain

@wesleymccollam wesleymccollam merged commit e178c19 into main Feb 9, 2026
10 checks passed
@wesleymccollam wesleymccollam deleted the remove-stale-keychain-entries branch February 9, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants