Add `changeStreetNLanes` functions #397

Grufoony · 2026-01-30T16:34:51Z

No description provided.

codecov · 2026-01-30T16:37:50Z

Codecov Report

❌ Patch coverage is 99.31507% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.59%. Comparing base (d787e02) to head (a9b050e).

Files with missing lines	Patch %	Lines
src/dsf/utility/queue.hpp	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   85.30%   85.59%   +0.28%     
==========================================
  Files          53       53              
  Lines        5941     6067     +126     
  Branches      652      658       +6     
==========================================
+ Hits         5068     5193     +125     
- Misses        862      863       +1     
  Partials       11       11

Flag	Coverage Δ
unittests	`85.59% <99.31%> (+0.28%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This pull request adds functionality to dynamically change the number of lanes on streets in a road network simulation. The PR introduces methods to modify lane counts both at the Street level and RoadNetwork level (by ID or by name), with optional speed factor adjustments to simulate scenarios like construction zones.

Changes:

Added Street::changeNLanes() method to modify lane count with optional speed adjustment
Added RoadNetwork::changeStreetNLanesById() and RoadNetwork::changeStreetNLanesByName() methods
Updated dsf::queue and dsf::priority_queue classes with move semantics and deleted copy operations
Added comprehensive test coverage for the new functionality
Exposed the new methods to Python through pybind11 bindings

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/dsf/mobility/Street.hpp	Added `changeNLanes()` method declaration and private helper `m_updateLaneMapping()`
src/dsf/mobility/Street.cpp	Implemented `changeNLanes()` and refactored lane mapping logic into helper method
src/dsf/mobility/RoadNetwork.hpp	Added `changeStreetNLanesById()` and `changeStreetNLanesByName()` method declarations
src/dsf/mobility/RoadNetwork.cpp	Implemented RoadNetwork-level lane change methods and added logging to `setStreetStatusById()`
src/dsf/utility/queue.hpp	Added move constructors/operators and deleted copy operations; added using directives for base constructors
src/dsf/bindings.cpp	Exposed new lane change methods to Python API
test/mobility/Test_street.cpp	Added comprehensive tests for `Street::changeNLanes()`
test/mobility/Test_graph.cpp	Added comprehensive tests for RoadNetwork lane change methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-30T16:40:21Z

src/dsf/mobility/RoadNetwork.cpp

+      pStreet->changeNLanes(nLanes);
+      if (speedFactor.has_value()) {
+        pStreet->setMaxSpeed(pStreet->maxSpeed() * speedFactor.value());
+      }


The Street::changeNLanes method already accepts an optional speedFactor parameter, but this implementation calls changeNLanes without it and then separately calls setMaxSpeed. Consider passing the speedFactor directly to changeNLanes instead: pStreet->changeNLanes(nLanes, speedFactor);. This would simplify the code and use the designed API more directly.

Copilot · 2026-01-30T16:40:21Z

src/dsf/mobility/Street.cpp

+    if (speedFactor.has_value()) {
+      m_maxSpeed = m_maxSpeed * speedFactor.value();
+    }
+    m_exitQueues.resize(m_nLanes);


When decreasing the number of lanes using m_exitQueues.resize(m_nLanes), agents in the removed queues will be lost. The queues contain std::unique_ptr<Agent>, so when the vector is resized down, the destructors will be called and the agents will be deleted. Consider handling these agents by moving them to remaining queues or throwing an error if there are agents present in the queues being removed.

Copilot · 2026-01-30T16:40:21Z

src/dsf/mobility/RoadNetwork.cpp

+      auto const& pStreet{edge(streetId)};
+      pStreet->changeNLanes(nLanes);
+      if (speedFactor.has_value()) {
+        pStreet->setMaxSpeed(pStreet->maxSpeed() * speedFactor.value());
+      }


The RoadNetwork maintains a total capacity (m_capacity) that is the sum of all street capacities. When a street's number of lanes is changed, its capacity changes, but the RoadNetwork's total capacity is not updated. This will cause the network's capacity to become out of sync with the actual sum of street capacities. Consider updating the network's capacity by calculating the delta (new capacity - old capacity) and adding it to m_capacity.

Copilot · 2026-01-30T16:40:22Z

src/dsf/mobility/RoadNetwork.cpp

+          auto const& pStreet = pair.second;
+          if (pStreet->name().find(streetName) != std::string::npos) {
+            pStreet->changeNLanes(nLanes);
+            if (speedFactor.has_value()) {
+              pStreet->setMaxSpeed(pStreet->maxSpeed() * speedFactor.value());
+            }
+            ++nAffectedRoads;
+          }
+        });


The RoadNetwork maintains a total capacity (m_capacity) that is the sum of all street capacities. When streets' number of lanes are changed, their capacities change, but the RoadNetwork's total capacity is not updated. This will cause the network's capacity to become out of sync with the actual sum of street capacities. Consider tracking capacity changes for all affected streets and updating the network's m_capacity accordingly.

Copilot · 2026-01-30T16:40:22Z

src/dsf/mobility/RoadNetwork.cpp

+            pStreet->changeNLanes(nLanes);
+            if (speedFactor.has_value()) {
+              pStreet->setMaxSpeed(pStreet->maxSpeed() * speedFactor.value());
+            }


The Street::changeNLanes method already accepts an optional speedFactor parameter, but this implementation calls changeNLanes without it and then separately calls setMaxSpeed. Consider passing the speedFactor directly to changeNLanes instead: pStreet->changeNLanes(nLanes, speedFactor);. This would simplify the code and use the designed API more directly.

Copilot · 2026-01-30T16:40:22Z

src/dsf/utility/queue.hpp

+    using std::queue<T, Container>::queue;
    typedef typename Container::iterator iterator;
    typedef typename Container::const_iterator const_iterator;

+    queue() = default;


The using std::queue<T, Container>::queue; directive at line 10 conflicts with the explicit queue() = default; constructor at line 14. When you use a using declaration to inherit constructors, you should not also explicitly declare the same constructors. The using declaration already brings in the default constructor from the base class. This can lead to ambiguity or compilation issues. Remove either the using declaration or the explicit queue() = default; declaration.

Copilot · 2026-01-30T16:40:22Z

src/dsf/utility/queue.hpp

    typedef typename Container::iterator iterator;
    typedef typename Container::const_iterator const_iterator;

+    priority_queue() = default;


The using std::priority_queue<T, Container, Compare>::priority_queue; directive at line 35 conflicts with the explicit priority_queue() = default; constructor at line 39. When you use a using declaration to inherit constructors, you should not also explicitly declare the same constructors. The using declaration already brings in the default constructor from the base class. This can lead to ambiguity or compilation issues. Remove either the using declaration or the explicit priority_queue() = default; declaration.

Suggested change

priority_queue() = default;

Copilot · 2026-01-30T16:40:23Z

src/dsf/utility/queue.hpp

+    priority_queue(const priority_queue&) = delete;
+    priority_queue& operator=(const priority_queue&) = delete;
+
    // c is a protected member of std::queue, which is the underlying container


The comment states "c is a protected member of std::queue" but should state "c is a protected member of std::priority_queue" since this is in the priority_queue class definition.

Suggested change

// c is a protected member of std::queue, which is the underlying container

// c is a protected member of std::priority_queue, which is the underlying container

Add changeStreetNLanes functions

a9b050e

Grufoony requested a review from Copilot January 30, 2026 16:34

Copilot started reviewing on behalf of Grufoony January 30, 2026 16:35 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `changeStreetNLanes` functions #397

Add `changeStreetNLanes` functions #397

Uh oh!

Grufoony commented Jan 30, 2026

Uh oh!

codecov bot commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// c is a protected member of std::queue, which is the underlying container
	// c is a protected member of std::priority_queue, which is the underlying container

Add changeStreetNLanes functions #397

Are you sure you want to change the base?

Add changeStreetNLanes functions #397

Uh oh!

Conversation

Grufoony commented Jan 30, 2026

Uh oh!

codecov bot commented Jan 30, 2026

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add `changeStreetNLanes` functions #397

Add `changeStreetNLanes` functions #397