Add trait bound ToString to Cell::new()/Cell::new_align()#94
Open
iosmanthus wants to merge 3 commits intophsym:masterfrom
Open
Add trait bound ToString to Cell::new()/Cell::new_align()#94iosmanthus wants to merge 3 commits intophsym:masterfrom
iosmanthus wants to merge 3 commits intophsym:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 84.05% 84.13% +0.08%
==========================================
Files 5 5
Lines 1179 1179
==========================================
+ Hits 991 992 +1
+ Misses 188 187 -1
Continue to review full report at Codecov.
|
Author
|
If I want to construct a fn pretty_matrix(matrix: [[u8; 16]; 16]) -> Table {
let mut table = Table::new();
matrix.iter().for_each(|line| {
table.add_row(Row::new(
line.iter().map(|x| Cell::new(&x.to_string())).collect::<Vec<_>>(),
));
});
table
}Now, the code becomes: fn pretty_matrix(matrix: [[u8; 16]; 16]) -> Table {
let mut table = Table::new();
matrix.iter().for_each(|line| {
table.add_row(Row::new(
line.iter().map(|x| Cell::new(x)).collect::<Vec<_>>(),
));
});
table
} |
Author
|
@phsym ping |
|
@iosmanthus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding trait bound
ToStringtoCell::new()/Cell::new_align(), maybe it will be more convenient to construct a row from another type because it will be unnecessary to transform the content to&strexplicitly.