Fix width calculation problem due to unicode-width update#174
Open
jackyzy823 wants to merge 1 commit intophsym:masterfrom
Open
Fix width calculation problem due to unicode-width update#174jackyzy823 wants to merge 1 commit intophsym:masterfrom
jackyzy823 wants to merge 1 commit intophsym:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt to fix #165
UnicodeWidthStr::width treats escape characters as 1 column wide now (previously it just iterates the string and apply UnicodeWidthChar::width on each character and sum the result up) .
However UnicodeWidthChar::width treats escape characters as
None.