Creation of prettytable-rs-derive and the creation of table from vector#115
Open
thymbahutymba wants to merge 3 commits intophsym:masterfrom
Open
Creation of prettytable-rs-derive and the creation of table from vector#115thymbahutymba wants to merge 3 commits intophsym:masterfrom
thymbahutymba wants to merge 3 commits intophsym:masterfrom
Conversation
…elf from get_field_name method
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 85.86% 86.15% +0.29%
==========================================
Files 5 5
Lines 1323 1351 +28
==========================================
+ Hits 1136 1164 +28
Misses 187 187
Continue to review full report at Codecov.
|
Author
|
I'm also wondering, do you want a PR that formats the code with rustfmt? |
Author
|
I was thinking about to make more generic the I'm not an expert of Rust so I'm asking for your feedback because you may noctice some trouble that may appear in such cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the mess that I've made trying to improve the
TableElemmethod removing&selffromget_field_nameThe code is already rebased. This should be a kind of final code which is the results of the previous commit and pull request #110