You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR introduces a non-intrusive handling of issue #150 which states that a PHP warning (Undefined array key) is issued during parsing in some cases (presumably when parsing non-standard UN/EDIFACT data).
Unit tests did pass locally but I noticed that code style fixing (vendor/bin/ecs) did not (and is not checked in CI). Should this be addressed, @sabas?
The code-style issue: We could add easy-coding-standard (ecs) as a step in the CI workflow (.github/workflows/ci.yml). This should be an easy fix and if you want, I will create another issue for this and provide a PR.
But the reason the CI pipeline fails is a different one, i.e. an authentication error. Sometimes re-running the build fixes the issue. Would you mind triggering another run? If it still fails, there are IMHO two things to consider:
I could imagine this has either something to do with the repositories configuration in the composer.json¹, which seems to be unnecessary (?!?) or
the Composer Action needs an access token, but this would be pretty unlikely because we deal with publicly available packages, altogether.
@sabas, let me know, if there is anything else, that needs to be done to get this merged. As for ecs: It just caught my eye and seemed useful. But I don't see a real necessity to integrate it into CI. So, from my point of view, the patch can be merged. Thanks, again, for your efforts!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a non-intrusive handling of issue #150 which states that a PHP warning (
Undefined array key) is issued during parsing in some cases (presumably when parsing non-standard UN/EDIFACT data).