Conversation
Following [RFC 5], add new JSON schemas for a `certs` property
containing JWS [JSON Serialization], supporting both the general and
flattened syntaxes. The schemas are:
* `certs.schema.json`: One or more certifications, with the `pgxn`
property required.
* `jws.schema.json`: JWS general and flattened [JSON Serialization]
* `jws-header.schema.json`: JWS headers
* `jwk.schema.json`: [RFC 7517] JSON Web Key (JWK) format, required by
the `jwk` property of `jws-header.schema.json`
* `payload.schema.json`: The PGXN release payload
Include tests for each of these schemas, and fix comments for existing
schema tests.
[RFC 5]: pgxn/rfcs#5
[JSON Serialization]: https://datatracker.ietf.org/doc/html/rfc7515#section-7
[RFC 7517]: https://datatracker.ietf.org/doc/html/rfc7517
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1083 1083
=========================================
Hits 1083 1083 ☔ View full report in Codecov by Sentry. |
vrmiguel
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add certs, JWS, payload schemas
Following RFC 5, add new JSON schemas for a
certsproperty containing JWSJSON Serialization, supporting both the general and flattened syntaxes. The
schemas are:
certs.schema.json: One or more certifications, with thepgxnproperty required.jws.schema.json: JWS general and flattened JSON Serializationjws-header.schema.json: JWS headersjwk.schema.json: RFC 7517 JSON Web Key (JWK) format, required by thejwkproperty ofjws-header.schema.jsonpayload.schema.json: The PGXN release payloadInclude tests for each of these schemas.