Allow pmstat to auto-hide unavailable columns#2421
Open
tallpsmith wants to merge 4 commits intoperformancecopilot:mainfrom
Open
Allow pmstat to auto-hide unavailable columns#2421tallpsmith wants to merge 4 commits intoperformancecopilot:mainfrom
tallpsmith wants to merge 4 commits intoperformancecopilot:mainfrom
Conversation
…ty of metrics. Pretty close, but column data is shifted right by a single column. This used Claude Code. (Even AI gets off-by-one errors?)
…er columns that were still showing up.
…e column detection method cleaner.
This change adds optional dynamic column hiding to pmstat, allowing it to automatically suppress columns for metrics that are unavailable on the current platform. This is particularly useful for macOS and other platforms where some Linux-specific metrics (like swap in/out, buffer memory, etc.) don't exist. Instead of showing "?" for missing values, the columns are simply not displayed. Usage: pmstat # Default: show all columns (original behavior) pmstat -C # Compact: hide unavailable metric columns Note: This commit is part of separating cross-platform tool improvements from platform-specific PMDA enhancements. Darwin PMDA swap metrics have been split into a separate PR for the macOS-specific enhancement branch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
tallpsmith
force-pushed
the
pmstat_dynamic_columns
branch
from
1443c0c to
c6bad09
Compare
tallpsmith
changed the title
Contributor
Author
|
@natoscott I don't mind if this is rejected and we leave it as existing behaviour - I initially thought this might be 'simple' and an interim usefulness until the bigger Darwin PMDA upgrade happened (which is nearly in), so if you're not really convinced (and I'm not entirely sure I am either now) then lets close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment,
pmstaton macOS is quite lean on what it can show because some metrics are not available (yet).I've modified
pmstatso that it (optionally) hides columns that are not available.I held several sessions with Claude Code to get here because it's certainly better at C than I am... After some back and forth I narrowed in on the
-Cand--compactmode forpmstatwhich seemed to not conflict with any other pm-tool that Claude looked at (and my fuzzy memory). I elected to make this compact mode optional, and not default, just to maintain backwards compatibility. There's certainly a 'brain freeze' moment when one runspmstatand sees a lot of columns missing, so I wondered if it was better to maintain the original layout (with missing metrics) as the default for us old folks...This goes towards #2303