-
Notifications
You must be signed in to change notification settings - Fork 2
feat: templates update #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @capobandito, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant improvement to our issue management workflow by pre-configuring all standard issue templates to automatically associate new issues with the "ZenBPM Product Backlog" project. This change aims to enhance project organization, streamline issue tracking, and reduce manual assignment efforts, ensuring that all relevant work items are consistently linked to our primary product backlog. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the issue templates to automatically add new issues to a specific project. The implementation is correct, but it introduces a hardcoded project identifier (pbinitiative/5) across multiple files without context. To improve long-term maintainability and clarity for future developers, I've suggested adding a comment to each template to document what this identifier refers to, based on the pull request description.
| title: "<short description>" | ||
| labels: ["type: bug"] | ||
| type: Bug | ||
| projects: ["pbinitiative/5"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project identifier pbinitiative/5 is a 'magic value' that isn't self-documenting. To improve maintainability, it's good practice to add a comment explaining which project this refers to. According to the PR description, this is the 'ZenBPM Product Backlog'. Adding this context will help future maintainers understand and update this configuration if needed.
# Corresponds to the "ZenBPM Product Backlog" project
projects: ["pbinitiative/5"]| title: "<short name>" | ||
| labels: ["type: epic"] | ||
| type: Epic | ||
| projects: ["pbinitiative/5"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project identifier pbinitiative/5 is a 'magic value' that isn't self-documenting. To improve maintainability, it's good practice to add a comment explaining which project this refers to. According to the PR description, this is the 'ZenBPM Product Backlog'. Adding this context will help future maintainers understand and update this configuration if needed.
# Corresponds to the "ZenBPM Product Backlog" project
projects: ["pbinitiative/5"]| title: "<short name>" | ||
| labels: ["type: initiative"] | ||
| type: Initiative | ||
| projects: ["pbinitiative/5"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project identifier pbinitiative/5 is a 'magic value' that isn't self-documenting. To improve maintainability, it's good practice to add a comment explaining which project this refers to. According to the PR description, this is the 'ZenBPM Product Backlog'. Adding this context will help future maintainers understand and update this configuration if needed.
# Corresponds to the "ZenBPM Product Backlog" project
projects: ["pbinitiative/5"]| title: "<short name>" | ||
| labels: ["type: task"] | ||
| type: Task | ||
| projects: ["pbinitiative/5"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project identifier pbinitiative/5 is a 'magic value' that isn't self-documenting. To improve maintainability, it's good practice to add a comment explaining which project this refers to. According to the PR description, this is the 'ZenBPM Product Backlog'. Adding this context will help future maintainers understand and update this configuration if needed.
# Corresponds to the "ZenBPM Product Backlog" project
projects: ["pbinitiative/5"]
To setup default project in the templates to the existing "ZenBPM Product Backlog"