Fix event handlers added to JavaConversionOptions.WarningEncountered not being removed after each converted file#144
Open
lordmilko wants to merge 1 commit intopaulirwin:masterfrom
Open
Conversation
…not being removed after each converted file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#146
In JavaToCSharpCli,
Program.ConvertToCSharpFileattaches an event handler to theJavaConversionOptions.WarningEncounteredevent handler. However, this event handler is not removed after theConvertToCSharpFilemethod finishes converting the file. As a result, when processing multiple files, every file you process will be added to the existing list of delegates attached to this event handler, resulting in all files processed so far receiving warnings that do not apply to them. This change updatesConvertToCSharpFileto ensure the event handler is unregistered prior to the method's return