Open
Conversation
added 2 commits
October 1, 2021 01:08
Author
|
I think i was wrong because there could be many instances of the activity in case when we have a loop or multiple processes and they all share one id, right? But how does it work if getActivityById called by definition return just one value, which one? I think we need something like getActivityByExecutionId and getElementByExecutionId. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Where is a headache to get parent's executionId by activity in some cases. For example if you will try something like:
const activity = execution.definitions[0].getActivityById('activityId');console.log(activity.parent.executionId);The result is undefined;
And activity gotten by subscription has a valid executionId:
listener.on('activity.start', activity => console.log(activity.content.parent.executionId));I investigated few places where it could be hidden and fixed it. I am not sure if it's a correct but it did a job.
Mainly i just distribute newly created executionId from ProcessExecution to starting activities and update already added children in ProcessExecution instance.
What do think?