Renaming time stamp field in API responses#2979
Conversation
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
jpodivin
requested review from
a team,
lbarcziova,
mfocko and
nforro
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request consistently renames the build_submitted_time field to submitted_time across multiple API endpoints (copr-builds, koji-builds, srpm-builds) to improve API consistency. The changes are also reflected in the test suite. I've suggested one improvement to make the API even more consistent by renaming other related fields.
| "status": build.status, | ||
| "chroot": build.target, | ||
| "build_submitted_time": optional_timestamp(build.submitted_time), | ||
| "submitted_time": optional_timestamp(build.submitted_time), |
There was a problem hiding this comment.
For consistency, it would be beneficial to also rename build_start_time and build_finished_time to start_time and finished_time respectively. This change would align them with the renaming of build_submitted_time and make the API more uniform. This should be applied to the other detail endpoints in koji_builds.py and srpm_builds.py as well. If you apply this change, please also update the release notes accordingly.
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 53s |
1 participant
I don't think it's necessary, nor wise, to merge this immediately. Since it is change to API and could break integration.
But it would be good to have the PR ready when the time comes.
RELEASE NOTES BEGIN
The
build_submitted_timeof responses from following API endpoints has been renamed tosubmitted_time.RELEASE NOTES END