Skip to content

Adding conditional Log Detective variables to configuration templates#687

Merged
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
jpodivin:logdetective
Feb 18, 2026
Merged

Adding conditional Log Detective variables to configuration templates#687
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
jpodivin:logdetective

Conversation

@jpodivin
Copy link
Contributor

I've used the same approach as utilized by other secrets. Both URL and token will be stored in bitwarden and rendered into template only if the URL is present. Log Detective interface server will always require authentication. Therefore, any configuration when URL is set, but the token is missing, is not viable.

Since removing the fields from configuration can be accomplished by just renaming, or removing, the variables in bitwarden, the fields were added to both prod and stage configuration templates.

RELEASE NOTES BEGIN

Log Detective URL and token are now conditional part of the service configuration.

RELEASE NOTES END

@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app
Copy link
Contributor

@nforro nforro requested a review from mfocko February 17, 2026 16:01
@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app
Copy link
Contributor

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
@nforro nforro added the mergeit Merge via Zuul label Feb 18, 2026
@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app centosinfra-prod-github-app bot merged commit 465f302 into packit:main Feb 18, 2026
5 of 6 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Packit pull requests Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

Development

Successfully merging this pull request may close these issues.

2 participants