Do not require flower authentication, nginx already handles it#682
Do not require flower authentication, nginx already handles it#682majamassarini wants to merge 1 commit intopackit:mainfrom
Conversation
With this change I can access the api/queues/length endpoint: curl -u "nginx-usr:nginx-pwd" "https://workers.stg.packit.dev/api/queues/length" otherwise I can't.
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 33s |
|
@majamassarini what about authentication with ? Have you tried utilise this somehow? |
yes, this is actually the nginx password. This is why the flower authentication shouldn't be needed. At the moment, we are only allowed to see those pages directly mapped in nginx -> /flower-metrics and /. But there are more pages flower exposes (like /queues/length or /tasks) which we can't access because of the above restriction. |
lbarcziova
left a comment
lbarcziova
left a comment
There was a problem hiding this comment.
resolved via chat, there is still the layer of auth via nginx, LGTM
|
@majamassarini can we merge this? |
2 participants
With this change I can access the api/queues/length endpoint:
curl -u "nginx-usr:nginx-pwd" "https://workers.stg.packit.dev/api/queues/length"
otherwise I can't.