Skip to content

Add fedora-ci for packages maintained by lecris#644

Merged
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom
LecrisUT:patch-1
Feb 19, 2025
Merged

Add fedora-ci for packages maintained by lecris#644
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom
LecrisUT:patch-1

Conversation

@LecrisUT
Copy link
Contributor

Here are a few packages that I maintain with various levels of permissions commit, collaborator, admin, maintainer. I guess the way to test it will be to open a bump PR and see if the scratch-build and testing-farm workflow work?

@softwarefactory-project-zuul
Copy link
Contributor

@lbarcziova
Copy link
Member

hi @LecrisUT ! We plan to announce this and provide all the information about the current state as part of packit/packit.dev#998. You can see the phases planned out in packit/packit-service#2692.

I guess the way to test it will be to open a bump PR and see if the scratch-build and testing-farm workflow work?

As mentioned in the issue above, the phase 1 consists only of scratch builds, and we plan to announce it after fixing the small bug packit/packit-service#2711. I can approve this PR if you're okay with that.
And another small note, you're enabling the packages for the staging instance, not production (for that, we use

enabled_projects_for_fedora_ci:
). This means there's a higher chance of something breaking occasionally. Is this intended?

@LecrisUT
Copy link
Contributor Author

Yep, for the beginning I will just test a few empty commit PRs, primarily checking that this enrollment works fine and it works for all levels of permission. I will also try to test if it correctly fails if sources are not uploaded to the lookaside cache.

@lbarcziova lbarcziova added the mergeit Merge via Zuul label Feb 19, 2025
@lbarcziova
Copy link
Member

lbarcziova commented Feb 19, 2025

The configuration was applied to staging.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0a39f92d6f4149239228d33a9339fe97

✔️ pre-commit SUCCESS in 1m 24s

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Merge already in progress

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Feb 19, 2025

Seems like github workflows on.pull_request do not have access to secrets. on.pull_request_target should work since it will take the definition and secret from the base repo (workflows/*.yaml and secrets is read from the base repo, but it takes github_ref from PR). So as long as someone doesn't echo SECRET in the tmt files it should be fine

@lbarcziova
Copy link
Member

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/f61f06de2d4b4a20a8fa97f651e89e35

✔️ pre-commit SUCCESS in 1m 23s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit dc5ac25 into packit:main Feb 19, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants