Cleaning up tests and dead code #524
Open
+1
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
|
Preview: https://packit-dashboard-pr-524.surge.sh (deployed at Fri 06 Feb 2026, 10:25 UTC) |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 39s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These things slightly bothered me when I my previous PR. I could have performed steeper cuts to this, but parts may still be of some use in the future.
Changes:
package.jsonin test docker fileutilsmodule, since the only function wasn't used anymoretest_architecture_imagetest case, as there is no architecture diagramI have kept data files used for testing and fixtures. Although I suspect that no tests are going to ever use them.