Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR preps the 1.3.2 release by updating module versions and refining the EventBus publish call to use the raw event payload. Sequence diagram for updated EventBus publish call in EventBusMessageBrokersequenceDiagram
participant EventBusMessageBroker
participant EventBus
EventBusMessageBroker->>EventBus: publish("events." + topic, event.event())
Class diagram for EventBusMessageBroker publish method changeclassDiagram
class EventBusMessageBroker {
+publish(String topic, TransactionalEvent event)
}
class TransactionalEvent {
+event()
}
EventBusMessageBroker --> TransactionalEvent: uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider centralizing the version in the root build.gradle or gradle.properties to avoid manual version bumps across each subproject.
- Double-check that switching to event.event() for publishing still satisfies all subscribers’ requirements and doesn’t omit necessary metadata.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing the version in the root build.gradle or gradle.properties to avoid manual version bumps across each subproject.
- Double-check that switching to event.event() for publishing still satisfies all subscribers’ requirements and doesn’t omit necessary metadata.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Prepare for 1.3.2 release by updating module versions and fix event bus publication to send the actual event payload.
Bug Fixes:
Build: