style!: use "Self" in generated code#936
Open
danieleades wants to merge 1 commit intooxidecomputer:mainfrom
Open
style!: use "Self" in generated code#936danieleades wants to merge 1 commit intooxidecomputer:mainfrom
danieleades wants to merge 1 commit intooxidecomputer:mainfrom
Conversation
danieleades
force-pushed
the
use-self
branch
from
bc5e970 to
e70c54b
Compare
Collaborator
|
What's the rationale here? |
Contributor
Author
|
Less redundant repetition of the struct name, less verbose, easier to refactor, makes constructors more obvious, less clippy warnings for downstream users using pedantic/nursery lints |
Collaborator
|
Is the description of this PR accurate? Generated code appears unaffected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates the codegen to use 'Self' to refer to own type.
this change is 'breaking' in the sense that the downstream code-gen tests in progenitor will need to be regenerated after pulling in this change