Skip to content

feat: remove split attributes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nadine-nguyen wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

feat: remove split attributes #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
630c42f
WIP: insert edits working, TODO: delete
nadine-nguyen May 11, 2021
7e302dd
WIP: still working on delete operation....
nadine-nguyen May 11, 2021
c14cfbd
WIP: fixed another edge case for deletes
nadine-nguyen May 11, 2021
ed348b6
fix: passing tests now... but now looking for edge cases...
nadine-nguyen May 11, 2021
d8194a8
fix: accounting for several attributes that may fall into the edit range
nadine-nguyen May 12, 2021
91d4cee
WIP: still not passing....
nadine-nguyen May 12, 2021
cee1dcb
WIP: refactor
nadine-nguyen May 13, 2021
0db5a80
fix: adding delete implementation
nadine-nguyen May 13, 2021
ebcd0ba
chore: removed unused code & comments
nadine-nguyen May 13, 2021
7ab3437
chore: removing more unused code
nadine-nguyen May 13, 2021
87c8dba
refactor: also add attributes that have been replaced in attribute tr…
nadine-nguyen May 13, 2021
c368149
test: for compose detectionId
nadine-nguyen May 13, 2021
043372c
test: skipping detection attr embed-like test
nadine-nguyen May 13, 2021
ccbb878
WIP: beginnings of compose() with invalid attr removal
nadine-nguyen May 13, 2021
0e67e69
fix: adding compose() validation but still not passing rich-text fuzz…
nadine-nguyen May 14, 2021
594bd60
fix: more fixes.... but still not passing
nadine-nguyen May 14, 2021
ffec33d
fix: more fixes for compose()
nadine-nguyen May 14, 2021
5fafe65
test: more tests compose()
nadine-nguyen May 14, 2021
3135979
test: tests for different transform() functionality based off new com…
nadine-nguyen May 15, 2021
ddd4c79
revert: revert transform() to original functionality, TODO: new trans…
nadine-nguyen May 16, 2021
b10d5e1
chore: small fixes to comments in transform-detections tests
nadine-nguyen May 16, 2021
c3f1996
fix: new transform() functionality
nadine-nguyen May 16, 2021
c4da5e4
refactor: transform() doesnt need to know about their own attributes,…
nadine-nguyen May 16, 2021
5e7b3f0
fix: compose() - now doesnt minus runningCursor on delete...
nadine-nguyen May 19, 2021
d6c400f
test: more tests...
nadine-nguyen May 19, 2021
626c14b
style: just renaming test variables so they make more sense
nadine-nguyen May 19, 2021
bef5b7a
test: another edge case for transform()
nadine-nguyen May 19, 2021
dbf9b4d
fix: fixing another edge case for transform(), but found another edge…
nadine-nguyen May 20, 2021
92c493a
fix: account for inserts being prioritised over deletes if they are a…
nadine-nguyen May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"eslint-plugin-prettier": "^3.1.2",
"istanbul": "~0.4.5",
"jasmine": "^3.5.0",
"lodash.partition": "^4.6.0",
"prettier": "^2.0.4",
"typescript": "^3.8.3"
},
Expand All @@ -34,7 +35,7 @@
"build": "tsc",
"prepare": "npm run build",
"lint": "eslint 'src/**/*.ts'",
"test": "npm run build; jasmine test/*.js test/**/*.js",
"test": "npm run build & jasmine test/*.js test/**/*.js",
"test:coverage": "istanbul cover jasmine test/*.js test/**/*.js",
"test:coverage:report": "cat coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js"
},
Expand Down
Loading