Skip to content

Comments

change deprecated get() call to input()#3073

Merged
tabuna merged 2 commits intoorchidsoftware:masterfrom
tsurowiec:deprecated-request-get-fix
Feb 13, 2026
Merged

change deprecated get() call to input()#3073
tabuna merged 2 commits intoorchidsoftware:masterfrom
tsurowiec:deprecated-request-get-fix

Conversation

@tsurowiec
Copy link
Contributor

@tsurowiec tsurowiec commented Feb 11, 2026

Fixes deprecation messages

Proposed Changes

replace deprecated request()->get() with recommended request()->query->get()

@tsurowiec
Copy link
Contributor Author

@tabuna the psalm errors are not related to my change, are they (confused)

@tabuna
Copy link
Member

tabuna commented Feb 13, 2026

@tsurowiec Yes, they are definitely not related to the proposed changes

@tabuna
Copy link
Member

tabuna commented Feb 13, 2026

I’m a bit concerned that the documentation suggests using the ->input() method.
Is there a reason why we’re not using it?

https://github.com/laravel/framework/blob/c50f17af167b539bd7930ef6ebce893b35b68b35/src/Illuminate/Http/Request.php#L436

@tsurowiec
Copy link
Contributor Author

tsurowiec commented Feb 13, 2026

I’m a bit concerned that the documentation suggests using the ->input() method. Is there a reason why we’re not using it?

noted, that's because I am more a Symfony guy, and ->input() is a Laravel thing - ->input() is a "catch them all wunderwaffe" - it would check also POST data, json (if payload sent as json) and few other places.

->input() would be more "laravel way", query->get() is more "targeted" - it would look only in query parameters where we expect _state to be

replace query->get() with input()
@tsurowiec
Copy link
Contributor Author

tsurowiec commented Feb 13, 2026

my bad 🙈 - it should be ->input(), as we sometimes send the _state as async POST request

updated the PR

@tsurowiec tsurowiec changed the title change deprecated get() call to query->get() change deprecated get() call to ->input() Feb 13, 2026
@tsurowiec tsurowiec changed the title change deprecated get() call to ->input() change deprecated get() call to input() Feb 13, 2026
@tabuna tabuna merged commit c475f0d into orchidsoftware:master Feb 13, 2026
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants