Check if the $url in the action button class has ended with /#2758
Open
silverhand7 wants to merge 1 commit intoorchidsoftware:masterfrom
Open
Check if the $url in the action button class has ended with /#2758silverhand7 wants to merge 1 commit intoorchidsoftware:masterfrom
silverhand7 wants to merge 1 commit intoorchidsoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement
I don't know if anyone ever needs this, but in my case, I set my Laravel application to always have a trailing slash at the end, and I came up with an issue that the URL in the button has a double slash before the method name:
Changes
If the
$urlin the action button class has ended with/no need to hard-coded additional/