You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review. 🎉
Walkthrough
This pull request refactors exception handling across the infrahub_sdk package to standardize exception chaining practices. Changes add explicit exception context preservation using from exc in several modules, including client, spec/object, and template. Conversely, other modules suppress context using from None for Typer exit and abort flows. The Ruff configuration is updated by removing B904 from the ignore list to enforce the "raise from" style within except blocks. Total changes span nine files with 14 lines added and 14 lines removed, consistently addressing exception chaining patterns throughout the codebase.
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name
Status
Explanation
Resolution
Description check
⚠️ Warning
The PR description is minimal and lacks key sections. It does not explain the problem being solved, the rationale for exception chaining, implementation details, testing approach, or potential impacts.
Expand the description to include: (1) Why proper exception chaining matters, (2) Which files were modified and why, (3) How to verify the changes, and (4) Any backward compatibility or behavioral implications.
Docstring Coverage
⚠️ Warning
Docstring coverage is 58.33% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name
Status
Explanation
Title check
✅ Passed
The title 'Reraise exceptions where applicable' directly aligns with the main changeset, which systematically adds proper exception chaining using 'from exc' syntax across multiple files.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remove exceptions to linting rules
What changed
Reraise exceptions where it might be relevant
Summary by CodeRabbit