Skip to content

Add none flag to daemon log and return error when no level provided #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvaroqui merged 1 commit into from
Feb 16, 2026
Merged

Add none flag to daemon log and return error when no level provided #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/commoncmd/daemon_log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ func NewCmdDaemonLog() *cobra.Command {
flags := cmd.Flags()
FlagNodeSelector(flags, &options.NodeSelector)
FlagDaemonLogLevel(flags, &options.Level)
_ = cmd.MarkFlagRequired("level")

return cmd
}

Expand Down
2 changes: 1 addition & 1 deletion core/commoncmd/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func FlagDaemonListenerName(flags *pflag.FlagSet, p *string) {
}

func FlagDaemonLogLevel(flags *pflag.FlagSet, p *string) {
flags.StringVar(p, "level", "", "trace, debug, info, warn, error, fatal, panic")
flags.StringVar(p, "level", "", "trace, debug, info, warn, error, fatal, panic, none")
}

func FlagDepth(flags *pflag.FlagSet, p *int) {
Expand Down
9 changes: 7 additions & 2 deletions daemon/daemonapi/post_daemon_log_control.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ func (a *DaemonAPI) PostDaemonLogControl(ctx echo.Context, nodename string) erro

func (a *DaemonAPI) postLocalDaemonLogControl(ctx echo.Context, payload api.LogControl) error {
var level string
if payload.Level != "none" {
level = string(payload.Level)
switch payload.Level {
case "":
return JSONProblemf(ctx, http.StatusBadRequest, "Invalid body", "missing 'level' field")
case "none":
// NoLevel
default:
level = payload.Level
}
newLevel, err := zerolog.ParseLevel(level)
if err != nil {
Expand Down