OCPBUGS-75009: skip dynamically adding map entries#726
OCPBUGS-75009: skip dynamically adding map entries#726jcmoraisjr wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
@jcmoraisjr: This pull request references Jira Issue OCPBUGS-75009, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
Tested it with 4.22.0-0-2026-02-04-071816-test-ci-ln-h9p6wnk-latest |
DCM updates frontend by adding new map entries. The new entries are however being added in the end of the map list, which can lead to requests being handled incorrectly in case of two distinct routes overlap their URLs. A proper fix is refactoring the maps entity, making it to sort map entries and replace all the map content. For now, we are skipping the DCM workflow if an add map operation is detected, moving to fork+reload instead.
a741e8a to
94d80ee
Compare
|
/assign @bentito |
|
/retest |
|
@jcmoraisjr: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
DCM updates frontend by adding new map entries. The new entries are however being added in the end of the map list, which can lead to requests being handled incorrectly in case of two distinct routes overlap their URLs.
A proper fix is refactoring the maps entity, making it to sort map entries and replace all the map content. For now, we are skipping the DCM workflow if an add map operation is detected, moving to fork+reload instead.
Jira: https://issues.redhat.com/browse/OCPBUGS-75009