OCPBUGS-75010: Change how DCM identifies state changes

[jcmoraisjr]

Router's dynamic update code (DCM) is identifying when state updates should be called via API by comparing the current running state, calling the API only if the state differs. This is not working on all possible states, e.g. server DOWN due to failing health check is being identified as MAINT, making the API call to be skipped.

Changed the approach by leaving the current state empty, and the code will always send the API call in case there is a need to be updated, despite on what is the current state.

Jira: https://issues.redhat.com/browse/OCPBUGS-75010

[openshift-ci-robot]

@jcmoraisjr: This pull request references NE-2477 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Router's dynamic update code (DCM) is identifying when state updates should be called via API by comparing the current running state, calling the API only if the state differs. This is not working on all possible states, e.g. server DOWN due to failing health check is being identified as MAINT, making the API call to be skipped.

Changed the approach by leaving the current state empty, and the code will always send the API call in case there is a need to be updated, despite on what is the current state.

Jira: https://issues.redhat.com/browse/NE-2477

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rfredette for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-75010, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Router's dynamic update code (DCM) is identifying when state updates should be called via API by comparing the current running state, calling the API only if the state differs. This is not working on all possible states, e.g. server DOWN due to failing health check is being identified as MAINT, making the API call to be skipped.

Changed the approach by leaving the current state empty, and the code will always send the API call in case there is a need to be updated, despite on what is the current state.

Jira: https://issues.redhat.com/browse/NE-2477

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-75010, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Router's dynamic update code (DCM) is identifying when state updates should be called via API by comparing the current running state, calling the API only if the state differs. This is not working on all possible states, e.g. server DOWN due to failing health check is being identified as MAINT, making the API call to be skipped.

Changed the approach by leaving the current state empty, and the code will always send the API call in case there is a need to be updated, despite on what is the current state.

Jira: https://issues.redhat.com/browse/OCPBUGS-75010

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lihongan]

/retest

[openshift-ci]

@jcmoraisjr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.