Skip to content

[release-4.20] NO-JIRA: Add new team members to OWNERS#698

Open
davidesalerno wants to merge 1 commit intoopenshift:release-4.20from
davidesalerno:add-me-to-owners-420
Open

[release-4.20] NO-JIRA: Add new team members to OWNERS#698
davidesalerno wants to merge 1 commit intoopenshift:release-4.20from
davidesalerno:add-me-to-owners-420

Conversation

@davidesalerno
Copy link
Contributor

@davidesalerno davidesalerno commented Dec 4, 2025 •
edited
Loading

This PR is a manual checcry-pick of #670

As a new member of the NID team I'm adding my github username to the OWNERS file

Note: this change is adding also @bentito

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2025

@davidesalerno: This pull request explicitly references no jira issue.

Details

In response to this:

This PR is a manual checcry-pick of #670

As a new member of the NID team I'm adding my github username to the OWNERS file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from candita and ironcladlou December 4, 2025 14:20
@davidesalerno davidesalerno changed the title NO-JIRA: Add davidesalerno to OWNERS [release-4.20] NO-JIRA: Add davidesalerno to OWNERS Dec 4, 2025
alebedev87
alebedev87 reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

@alebedev87 alebedev87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025
@alebedev87
Copy link
Contributor

alebedev87 commented Dec 4, 2025

/hold

To let #695 go first. Can be unhold once the 695 is merged.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2025
@davidesalerno
Add new team members to OWNERS
b4e6768 
Signed-off-by: Davide Salerno <dsalerno@redhat.com>
@davidesalerno davidesalerno changed the title [release-4.20] NO-JIRA: Add davidesalerno to OWNERS [release-4.20] NO-JIRA: Add new team members to OWNERS Dec 4, 2025
@alebedev87
Copy link
Contributor

alebedev87 commented Dec 4, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2025

@davidesalerno: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alebedev87
Copy link
Contributor

alebedev87 commented Dec 8, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2025
@alebedev87
Copy link
Contributor

alebedev87 commented Jan 13, 2026

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 13, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2026

@alebedev87: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87 alebedev87 mentioned this pull request Jan 13, 2026
Closed
@bentito
Copy link
Contributor

bentito commented Feb 6, 2026

I think the title:
[release-4.20] NO-JIRA: Add new team members to OWNERS
needs to be instead:
NO-JIRA: [release-4.20] Add new team members to OWNERS

in order to get the jira/valid-bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@candita candita Awaiting requested review from candita

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

1 more reviewer

@alebedev87 alebedev87 alebedev87 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alebedev87 alebedev87

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidesalerno @openshift-ci-robot @alebedev87 @bentito