Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lance5890 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @lance5890. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| memory: 100Mi | ||
| - name: exporter | ||
| image: quay.io/openshift/origin-insights-runtime-exporter:latest | ||
| imagePullPolicy: Always |
There was a problem hiding this comment.
The kube-rbac-proxy container has not set the Always imagePullPolicy
|
/label ok-to-test |
|
@opokornyy: Can not set label ok-to-test: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight openshift-sustaining-engineers] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
b0a19a3 to
a0bc9a7
Compare
a0bc9a7 to
ff4c71b
Compare
|
/retest-required |
|
@lance5890: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
This PR implements a new data enhancement to...
Categories
exporterandexporterhas no need to use theimagePullPolicy: Alwaysfor the containers, as the ocp will replace theimage: quay.io/openshift/origin-insights-runtime-exporter:latestto sha256 digest when create ocp release, thelatesttag will not pull the latest image in the ocp versions.Sample Archive
path/to/sample_data.jsonDocumentation
path/to/documentation.mdUnit Tests
path/to/file_test.goPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
Yes/No
References
https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???