use secure cipher suites for operator#1130
use secure cipher suites for operator#1130lance5890 wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Hi @lance5890. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lance5890 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/retest |
|
Hello there @lance5890 First of all thanks for your contribution and interest in our project. Could you explain the meaning or purpose of this PR a bit more? |
no special issue here, I just found the insight-operator logs show that it need permissions for replicasets(this is resolving by #1123), and it also shows the insecure cipher(which might be potential risks if the operator exposes metrics or services now or the future) |
|
/retest |
1 similar comment
|
/retest |
|
@lance5890: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
This PR implements a new data enhancement to...
As the operator log shows it uses
Use of insecure ciphersuites such as:And the logs also showed that the operator need more permissions for replicasets, but this is resolved by #1123
Categories
Sample Archive
path/to/sample_data.jsonDocumentation
path/to/documentation.mdUnit Tests
path/to/file_test.goPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
Yes/No
References
https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???