Skip to content

ESO-275: Updates bundle name to distinguish from the upstream helm installations#98

Open
bharath-b-rh wants to merge 1 commit intoopenshift:mainfrom
bharath-b-rh:eso-275
Open

ESO-275: Updates bundle name to distinguish from the upstream helm installations#98
bharath-b-rh wants to merge 1 commit intoopenshift:mainfrom
bharath-b-rh:eso-275

Conversation

@bharath-b-rh
Copy link
Contributor

@bharath-b-rh bharath-b-rh commented Jan 20, 2026

The PR is for updating the operator name from external-secrets-operator to openshift-external-secrets-operator to distinguish the downstream deployments from upstream deployments.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2026

@bharath-b-rh: This pull request references ESO-275 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "eso-1.1" instead.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Walkthrough

Renamed operator from external-secrets-operator to openshift-external-secrets-operator across project config, bundle labels/annotations, CSV manifests (metadata.name, createdAt, added replaces, and removed an image reference), kustomization base, and a CI/git-check script reference.

Changes

Cohort / File(s) Summary
Project config & bundle labels
PROJECT, bundle.Dockerfile, bundle/metadata/annotations.yaml
Changed projectName and operators.package label/annotation values from external-secrets-operator to openshift-external-secrets-operator.
Bundle CSV manifest
bundle/manifests/openshift-external-secrets-operator.clusterserviceversion.yaml
Updated metadata.name and metadata.createdAt, added spec.replaces: external-secrets-operator.v1.0.0, and removed a ghcr.io/external-secrets/bitwarden-sdk-server:v0.5.2 image reference.
Config manifests (kustomize base)
config/manifests/bases/openshift-external-secrets-operator.clusterserviceversion.yaml, config/manifests/kustomization.yaml
Renamed CSV metadata.name, added spec.provider.replaces: external-secrets-operator.v1.0.0, and updated kustomization to reference the new base CSV filename.
Scripts / CI checks
hack/check-git-diff-clean.sh
Updated script to ignore the new bundle CSV path bundle/manifests/openshift-external-secrets-operator.clusterserviceversion.yaml when checking expected diffs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2026

@bharath-b-rh: This pull request references ESO-275 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "eso-1.1" instead.

Details

In response to this:

The PR is for updating the operator name from external-secrets-operator to openshift-external-secrets-operator to distinguish the downstream deployments from upstream deployments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bharath-b-rh bharath-b-rh marked this pull request as ready for review February 4, 2026 06:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026
@openshift-ci openshift-ci bot requested review from TrilokGeer and swghosh February 4, 2026 06:02
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@bundle/manifests/openshift-external-secrets-operator.clusterserviceversion.yaml`:
- Line 845: The CSV's replaces field currently points to a CSV in a different
package ("external-secrets-operator.v1.0.0"); update the replaces entry to the
matching package name by changing the replaces value to
"openshift-external-secrets-operator.v1.0.0" so the CSV replaces target is in
the same package as the current CSV (modify the replaces field in the
clusterserviceversion YAML).

@mytreya-rh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@bharath-b-rh
Copy link
Contributor Author

/label px-approved

@emmajiafan Could you please help with verified label. Also I think openshift/external-secrets-operator-release#230 is required to verify end-to-end. Thank you!

@snarayan-redhat Could you please help with docs label. We need to add details in the RN. The operator CSV name is updated from external-secrets-operator to openshift-external-secrets-operator to keep it aligned with the package name. There is no user intervention required, the upgrade will happen seamlessly. Thank you!

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Feb 4, 2026
…stallations

Signed-off-by: Bharath B <bhb@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 5, 2026

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mytreya-rh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants