OCPBUGS-74521: Remove VolumeAttributesClass FeatureGate

[dfajmon]

PR Type

Enhancement

---

Description

• Remove VolumeAttributesClass FeatureGate definition

• Delete feature gate from all Hypershift deployment manifests

• Delete feature gate from all SelfManagedHA deployment manifests

• Remove feature gate entry from documentation table

---

Diagram Walkthrough

flowchart LR
  A["VolumeAttributesClass FeatureGate"] -->|removed from| B["features.go"]
  A -->|removed from| C["features.md documentation"]
  A -->|removed from| D["Hypershift manifests"]
  A -->|removed from| E["SelfManagedHA manifests"]

Loading

File Walkthrough

	Relevant files
Enhancement	1 files features.go Remove VolumeAttributesClass feature gate definition          +0/-8
Documentation	1 files features.md Remove VolumeAttributesClass from feature table                    +0/-1
Configuration changes	8 files featureGate-Hypershift-Default.yaml Remove VolumeAttributesClass from default manifest              +0/-3      featureGate-Hypershift-DevPreviewNoUpgrade.yaml Remove VolumeAttributesClass from dev preview manifest      +0/-3      featureGate-Hypershift-OKD.yaml Remove VolumeAttributesClass from OKD manifest                      +0/-3      featureGate-Hypershift-TechPreviewNoUpgrade.yaml Remove VolumeAttributesClass from tech preview manifest    +0/-3      featureGate-SelfManagedHA-Default.yaml Remove VolumeAttributesClass from default manifest              +0/-3      featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml Remove VolumeAttributesClass from dev preview manifest      +0/-3      featureGate-SelfManagedHA-OKD.yaml Remove VolumeAttributesClass from OKD manifest                      +0/-3      featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml Remove VolumeAttributesClass from tech preview manifest    +0/-3

---

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @dfajmon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@dfajmon: This pull request references Jira Issue OCPBUGS-74521, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request removes the VolumeAttributesClass feature gate from the codebase. This includes deleting its exported declaration from the feature gates Go code, removing its documentation entry from the features table, and eliminating it from all feature gate configuration manifests across deployment scenarios (Hypershift and SelfManagedHA with Default, DevPreviewNoUpgrade, OKD, and TechPreviewNoUpgrade profiles).

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author; however, the PR title and objectives clearly indicate this removes the VolumeAttributesClass FeatureGate, which is directly reflected in the changeset across all modified files.	Author should provide a pull request description explaining the rationale for removing the VolumeAttributesClass FeatureGate and any related context or migration guidance.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically identifies the main change: removal of the VolumeAttributesClass FeatureGate, which is confirmed across all modified files in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@dfajmon: This pull request references Jira Issue OCPBUGS-74521, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

Details

In response to this:

PR Type

Enhancement

---

Description

• Remove VolumeAttributesClass FeatureGate definition

• Delete feature gate from all Hypershift deployment manifests

• Delete feature gate from all SelfManagedHA deployment manifests

• Remove feature gate entry from documentation table

---

Diagram Walkthrough

flowchart LR
 A["VolumeAttributesClass FeatureGate"] -->|removed from| B["features.go"]
 A -->|removed from| C["features.md documentation"]
 A -->|removed from| D["Hypershift manifests"]
 A -->|removed from| E["SelfManagedHA manifests"]

Loading

File Walkthrough

	Relevant files
Enhancement	1 files features.go Remove VolumeAttributesClass feature gate definition          +0/-8
Documentation	1 files features.md Remove VolumeAttributesClass from feature table                    +0/-1
Configuration changes	8 files featureGate-Hypershift-Default.yaml Remove VolumeAttributesClass from default manifest              +0/-3      featureGate-Hypershift-DevPreviewNoUpgrade.yaml Remove VolumeAttributesClass from dev preview manifest      +0/-3      featureGate-Hypershift-OKD.yaml Remove VolumeAttributesClass from OKD manifest                      +0/-3      featureGate-Hypershift-TechPreviewNoUpgrade.yaml Remove VolumeAttributesClass from tech preview manifest    +0/-3      featureGate-SelfManagedHA-Default.yaml Remove VolumeAttributesClass from default manifest              +0/-3      featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml Remove VolumeAttributesClass from dev preview manifest      +0/-3      featureGate-SelfManagedHA-OKD.yaml Remove VolumeAttributesClass from OKD manifest                      +0/-3      featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml Remove VolumeAttributesClass from tech preview manifest    +0/-3

---

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

No code suggestions found for the PR.

[JoelSpeed]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Phaow]

/retest-required

[JoelSpeed]

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-serial-techpreview

These are hangovers from a bug in the pipeline controller and should not be here

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial, ci/prow/e2e-aws-serial-techpreview

Details

In response to this:

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-serial-techpreview

These are hangovers from a bug in the pipeline controller and should not be here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JoelSpeed]

/retest

[JoelSpeed]

/retest

[dfajmon]

/retest

[Phaow]

/test e2e-aws-serial-1of2

[qodo-code-review]

PR-Agent: could not fine a component named e2e-aws-serial-1of2 in a supported language in this PR.

[dfajmon]

/test e2e-aws-serial-1of2

[qodo-code-review]

PR-Agent: could not fine a component named e2e-aws-serial-1of2 in a supported language in this PR.

[JoelSpeed]

/verified by CI

No further verification needed on this if CI passes

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

No further verification needed on this if CI passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@dfajmon: Jira Issue OCPBUGS-74521: Some pull requests linked via external trackers have merged:

• openshift/api#2675

The following pull request, linked via external tracker, has not merged:

• openshift/gcp-pd-csi-driver#91 is closed

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-74521 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

PR Type

Enhancement

---

Description

• Remove VolumeAttributesClass FeatureGate definition

• Delete feature gate from all Hypershift deployment manifests

• Delete feature gate from all SelfManagedHA deployment manifests

• Remove feature gate entry from documentation table

---

Diagram Walkthrough

flowchart LR
 A["VolumeAttributesClass FeatureGate"] -->|removed from| B["features.go"]
 A -->|removed from| C["features.md documentation"]
 A -->|removed from| D["Hypershift manifests"]
 A -->|removed from| E["SelfManagedHA manifests"]

Loading

File Walkthrough

	Relevant files
Enhancement	1 files features.go Remove VolumeAttributesClass feature gate definition          +0/-8
Documentation	1 files features.md Remove VolumeAttributesClass from feature table                    +0/-1
Configuration changes	8 files featureGate-Hypershift-Default.yaml Remove VolumeAttributesClass from default manifest              +0/-3      featureGate-Hypershift-DevPreviewNoUpgrade.yaml Remove VolumeAttributesClass from dev preview manifest      +0/-3      featureGate-Hypershift-OKD.yaml Remove VolumeAttributesClass from OKD manifest                      +0/-3      featureGate-Hypershift-TechPreviewNoUpgrade.yaml Remove VolumeAttributesClass from tech preview manifest    +0/-3      featureGate-SelfManagedHA-Default.yaml Remove VolumeAttributesClass from default manifest              +0/-3      featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml Remove VolumeAttributesClass from dev preview manifest      +0/-3      featureGate-SelfManagedHA-OKD.yaml Remove VolumeAttributesClass from OKD manifest                      +0/-3      featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml Remove VolumeAttributesClass from tech preview manifest    +0/-3

---

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.