Fix redfish_verify_ca boolean handling in certificate#1839
Fix redfish_verify_ca boolean handling in certificate#1839rbbratta wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @rbbratta. Thanks for your PR. I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The code was checking for the string 'False' (capital F), but when jq extracts a boolean false from JSON, it outputs 'false' (lowercase). This caused the check to fail, resulting in TLS verification being enabled even when redfish_verify_ca was set to false in nodes.json. Fixed by checking for both 'False' and 'false' in both: - utils.sh: node_map_to_install_config_hosts() function - ocp_install_env.sh: generate_ocp_host_manifest() function This ensures that disableCertificateVerification is correctly set to true when redfish_verify_ca is false, allowing Ironic to connect to iDRAC Redfish endpoints with self-signed certificates. Related to PR 1812 which enabled TLS validation for Redfish emulator.
|
/ok-to-test |
|
@rbbratta: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The code was checking for the string 'False' (capital F), but when jq extracts a boolean false from JSON, it outputs 'false' (lowercase). This caused the check to fail, resulting in TLS verification being enabled even when redfish_verify_ca was set to false in nodes.json.
Fixed by checking for both 'False' and 'false' in both:
This ensures that disableCertificateVerification is correctly set to true when redfish_verify_ca is false, allowing Ironic to connect to iDRAC Redfish endpoints with self-signed certificates.
Related to PR 1812 which enabled TLS validation for Redfish emulator.
Cursor GPT-5.2 generated.