Skip to content

Conversation

@gmacf
Copy link
Contributor

@gmacf gmacf commented Jan 14, 2026

This PR updates the Bootz readme to clarify the expected behavior for reporting status on modular devices. It makes it clear that devices should report both control cards as initialized for Bootz to complete.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20999685087

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 18.768%

Totals Coverage Status
Change from base Build 20977771903: 0.0%
Covered Lines: 640
Relevant Lines: 3410

💛 - Coveralls

@gmacf gmacf marked this pull request as draft January 14, 2026 15:48
Comment on lines +343 to +347
- In a modular chassis, the device MUST populate `states` with
`CONTROL_CARD_STATUS_INITIALIZED` for two control cards. For example,
a `BOOTSTRAP_STATUS_SUCCESS` report for a modular chassis with one
state set to `CONTROL_CARD_STATUS_INITIALIZED` and one state set to
`CONTROL_CARD_STATUS_NOT_INITIALIZED` will be ignored by bootz-server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- In a modular chassis, the device MUST populate `states` with
`CONTROL_CARD_STATUS_INITIALIZED` for two control cards. For example,
a `BOOTSTRAP_STATUS_SUCCESS` report for a modular chassis with one
state set to `CONTROL_CARD_STATUS_INITIALIZED` and one state set to
`CONTROL_CARD_STATUS_NOT_INITIALIZED` will be ignored by bootz-server.
- In a modular chassis, the device MUST populate `states` with
`CONTROL_CARD_STATUS_INITIALIZED` for each `CONTROLLER_CARD` present in the chassis.
For example, a `BOOTSTRAP_STATUS_SUCCESS` report from a modular chassis containing two
`CONTROLLER_CARD` components must not set one `CONTROLLER_CARD`
stat to `CONTROL_CARD_STATUS_INITIALIZED` and the second `CONTROLLER_CARD` state to
`CONTROL_CARD_STATUS_NOT_INITIALIZED`. Such a status will be treated as invalid by a bootz-server.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested this because it's possible that a modular chassis could contain only one CONTROLLER_CARD component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants