Complete the syntax for the integer fragment of the arith dialect#241
Merged
tobiasgrosser merged 2 commits intomainfrom Feb 23, 2026
Merged
Complete the syntax for the integer fragment of the arith dialect#241tobiasgrosser merged 2 commits intomainfrom
tobiasgrosser merged 2 commits intomainfrom
Conversation
This PR only stablished syntax, but no semantics yet. It is pulled out of PR #219. We also increase the max recursion limit as the generation of the opcode inductive requires a deeper limit. Co-authored-by: Alexander Viand <AlexanderViand@gmail.com>
tobiasgrosser
requested review from
AlexanderViand,
ineol,
luisacicolini and
math-fehr
Contributor
|
Thanks! I also have some partially vibe-coded, partially hand-reviewed interpreter semantics for the arith ops (on a local branch, I think 🙈) but I'm not sure if it's more work for @math-fehr to review those or to write them himself or write some documentation on what the intended semantics are first? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only stablished syntax, but no semantics yet. It is pulled out of PR #219.
We also increase the max recursion limit as the generation of the opcode inductive requires a deeper limit.