Draft
Conversation
math-fehr
reviewed
Feb 21, 2026
| let ⟨ctx, h_ctx_FieldsInBound⟩ ← getContext | ||
| let h_block_InBounds : block.InBounds ctx := by sorry | ||
| let ctx' := block.setArguments ctx blockArguments h_block_InBounds | ||
| setContext ctx' (by |
Collaborator
There was a problem hiding this comment.
I added the missing lemma in #226, this should make this proof much much simpler!
If you rebase on the PR, you should be able to replace this with
setContext ctx' (by
apply BlockPtr.setArguments_fieldsInBounds
· sorry -- Need to prove that the block had no arguments before
· sorry -- Need to prove that the new arguments are FieldsInBounds
· grind)
I'll merge the PR this week-end!
math-fehr
reviewed
Feb 21, 2026
| ptr.InBounds (setPrevBlock block ctx newPrevBlock h) ↔ ptr.InBounds ctx := by | ||
| grind | ||
|
|
||
| @[grind =] |
math-fehr
reviewed
Feb 21, 2026
| ctx.FieldsInBounds → (setRegions op ctx newRegions h).FieldsInBounds := by | ||
| prove_fieldsInBounds_operation ctx | ||
|
|
||
| @[grind .] |
Collaborator
|
@GZGavinZhao, it might make sense to update this PR on latest |
Collaborator
Author
|
Yep, thanks for the reminder, I'll do that tonight / early tomorrow and see how well it goes! |
GZGavinZhao
force-pushed
the
gzgz/verified-parser
branch
2 times, most recently
from
c0742f8 to
b39fb84
Compare
GZGavinZhao
force-pushed
the
gzgz/verified-parser
branch
from
b39fb84 to
05f7ccb
Compare
GZGavinZhao
force-pushed
the
gzgz/verified-parser
branch
from
05f7ccb to
0b3cb5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For visibility and comments if desired.