Merged
Conversation
…ting failed in tabledata format. Replaced hasFailure var to be a local var instead of class var. Updated row-count calculation logic.
pdowler
requested changes
Nov 21, 2025
| rowCount ++; | ||
| List<Object> row = rowIter.next(); | ||
| writeRow(out, row); | ||
| success = writeRow(out, row); |
Member
There was a problem hiding this comment.
I think the structure used in the BinaryElementWriter, where writeRow(...) just throws whatever exception occurs and the try/catch (set trailer and break) is in the while loop is simpler and works for all failures.
Please update the TableDataElementWriter to the same structure.
pdowler
previously approved these changes
Nov 21, 2025
pdowler
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop iterating if writing a row in TableData or Binary format failed.