Refactor groups classes (CADC-14501)#201
Conversation
pdowler
left a comment
pdowler
left a comment
There was a problem hiding this comment.
I would put the cadc-rest based groups code into ac directly and not in the library, in a package named org.opencadc.ac (for now). It's essentially a fork on that code, moved to new package.... you could just leave the old library code alone for now. I don't think the diffs will be useful enough.
It is harder than necessary to put action code into a lib and make them configurable in a service and there is no need here.
...ccess-control-server/src/main/java/ca/nrc/cadc/ac/server/web/groups/InlineContentAction.java
Outdated
Show resolved
Hide resolved
cadc-access-control-server/src/main/java/ca/nrc/cadc/ac/server/web/groups/GroupsConfig.java
Outdated
Show resolved
Hide resolved
pdowler
left a comment
pdowler
left a comment
There was a problem hiding this comment.
Couple more general comments after trying to deploy and run integration tests:
There is no README documenting the required config, specifically the new file ac.properties. Please add and follow the standard form from other locations. You will need to remove the part about IdentityManager config for now since ac has a hard-coded internal one.
2 participants
No description provided.