ACIdentityManager.toSubject also reconstruct from X509 DN#199
Merged
pdowler merged 2 commits intoopencadc:mainfrom Oct 24, 2025
Merged
ACIdentityManager.toSubject also reconstruct from X509 DN#199pdowler merged 2 commits intoopencadc:mainfrom
pdowler merged 2 commits intoopencadc:mainfrom
Conversation
andamian
reviewed
Oct 24, 2025
| return ret; | ||
| } | ||
|
|
||
| // package access for unit test |
Contributor
There was a problem hiding this comment.
JavaDoc? Why this name? Is this meant to be used directly when the original principal is sufficient?
Member
Author
There was a problem hiding this comment.
I don't normally javadoc things that are internal
no, it is just pulled out of the other method so it can be unit-tested; it only gets called from the normal toSubject method and never on it's own. The comment just explains why it is package access.
I decided that the augment wasn't worth avoiding for config use since it only happens once at startup
andamian
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.