Remove shift from install-nginx-attachment.sh#10
Open
superpuffin wants to merge 1 commit intoopenappsec:mainfrom
Open
Remove shift from install-nginx-attachment.sh#10superpuffin wants to merge 1 commit intoopenappsec:mainfrom
superpuffin wants to merge 1 commit intoopenappsec:mainfrom
Conversation
Shift is unecessary here, since we are already picking the first argument (i.e. $1 instead of $0, which would be the command).
|
Yes, shift causes error when running the script. No args: "$# = 0" → shift ⇒ error This needs to be approved. Pls. |
anmolbhat
approved these changes
Jan 19, 2026
anmolbhat
left a comment
There was a problem hiding this comment.
No args: "$# = 0" → shift ⇒ error
initial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift is unecessary here, since we are already picking the first argument (i.e. $1 instead of $0, which would be the command).