Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b1fc9c58d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codex-rs/core/src/file_watcher.rs
Outdated
| roots.iter().any(|root| { | ||
| path.starts_with(root) | ||
| && path | ||
| .file_name() | ||
| .is_some_and(|file_name| file_name == SKILL_FILE_NAME) |
There was a problem hiding this comment.
The new filter only emits when the changed path’s filename is SKILL.md, so updates to skill metadata files (e.g., agents/openai.yaml loaded in load_skill_metadata in codex-rs/core/src/skills/loader.rs) will no longer trigger a reload. That means edits to interface/dependency metadata won’t be reflected until SKILL.md is touched or the process restarts, which is a regression from the previous “any file under skills root” behavior.
Useful? React with 👍 / 👎.
xl-openai
changed the title
1 participant
External (non-OpenAI) Pull Request Requirements
Avoid over-triggering.