feat: do not close unified exec processes across turns#10799
feat: do not close unified exec processes across turns#10799
Conversation
…esses # Conflicts: # codex-rs/app-server/src/codex_message_processor.rs
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fc01ea34e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…esses # Conflicts: # codex-rs/app-server-protocol/schema/typescript/ClientRequest.ts # codex-rs/app-server/README.md
…esses # Conflicts: # codex-rs/exec/src/lib.rs
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9353331036
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
With this PR we do not close the unified exec processes (i.e. background terminals) at the end of a turn unless:
app-serveror/cleanI made sure that
codex execcorrectly kill all the processes