Conversation
| }; | ||
|
|
||
| void loadIntegrations(); | ||
| }, []); |
There was a problem hiding this comment.
I think it would be cleaner if components don't do data fetching by themselves.
Instead it should be done in the route loader and passed as props to the component, what do you think?
That will also allow to use the loading (and eventually Suspense) mechanisms.
| .min(1, "Please select at least one sensor"), | ||
| }); | ||
|
|
||
| const mqttSchema = z |
There was a problem hiding this comment.
The mqttSchema contains the ttnConfig?
Can we somehow make this dependent on the available integrations? 🤔 Some sort of generic schema or something..
| // .superRefine((data, ctx) => { | ||
| // if (data.mqttEnabled) { | ||
| // // Check required fields when enabled is true | ||
| // if (!data.url) { | ||
| // ctx.addIssue({ | ||
| // path: ["url"], | ||
| // message: "URL is required when MQTT is enabled.", | ||
| // code: "custom", | ||
| // }); | ||
| // } | ||
| // if (!data.topic) { | ||
| // ctx.addIssue({ | ||
| // path: ["topic"], | ||
| // message: "Topic is required when MQTT is enabled.", | ||
| // code: "custom", | ||
| // }); | ||
| // } | ||
| // if (!data.messageFormat) { | ||
| // ctx.addIssue({ | ||
| // path: ["messageFormat"], | ||
| // message: "Message format is required when MQTT is enabled.", | ||
| // code: "custom", | ||
| // }); | ||
| // } | ||
| // } | ||
| // }); |
| }); | ||
|
|
||
| const advancedSchema = z.intersection(mqttSchema, ttnSchema) | ||
| // const advancedSchema = z.intersection(mqttSchema, ttnSchema); |
| [stepper.current.id]: data, | ||
| } | ||
| const onSubmit = (data: FormData) => { | ||
| console.log("🚀 ~ onSubmit ~ data", data); |
| name: text('name').notNull(), | ||
| slug: text('slug').notNull().unique(), | ||
| serviceUrl: text('service_url').notNull(), | ||
| serviceKeyEnvVar: text('service_key_env_var').notNull(), |
There was a problem hiding this comment.
do we care if the serviceKey is an envVar? It is not used as one by osem right?
So why not keep it simple and call it serviceKey?
| slug: text('slug').notNull().unique(), | ||
| serviceUrl: text('service_url').notNull(), | ||
| serviceKeyEnvVar: text('service_key_env_var').notNull(), | ||
| schemaPath: text('schema_path').notNull(), |
There was a problem hiding this comment.
Isn't it derivable from the serviceUrl?
Your docs state **GET /integrations/schema/{name}**, but I don't fully get the {name} part.
Can a service provide multiple schemas? If so, this can't just be a column and must be a one to many relationship, no?
| MQTT_SERVICE_URL: z.string(), | ||
| MQTT_SERVICE_KEY: z.string() |
There was a problem hiding this comment.
remove for the generic approach?
There was a problem hiding this comment.
Maybe this should be part of the docker-compose file too?
There was a problem hiding this comment.
Did you mean to check these in?
They are generated files no?
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
2 participants
Type of Change
Implementation
Checklist
devbranchAdditional Information