Open
Conversation
apaolillo
requested changes
Jan 15, 2026
benchkit/communication/__init__.py
Outdated
| import os | ||
| import os.path | ||
| import subprocess | ||
| from abc import ABC, abstractmethod |
Collaborator
There was a problem hiding this comment.
we don't use ABC in benchkit.
benchkit/communication/pty.py
Outdated
| # Copyright (C) 2026 Vrije Universiteit Brussel. All rights reserved. | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| from __future__ import annotations |
| @@ -0,0 +1,194 @@ | |||
| # Copyright (C) 2026 Vrije Universiteit Brussel. All rights reserved. | |||
| # SPDX-License-Identifier: MIT | |||
Collaborator
There was a problem hiding this comment.
could you give docstring documentation for this module.
benchkit/communication/pty.py
Outdated
| or ignore_any_error_code | ||
| or ignore_ret_codes != () | ||
| ): | ||
| raise PTYException("Not supported attributes") |
Collaborator
There was a problem hiding this comment.
Suggested change
| raise PTYException("Not supported attributes") | |
| raise PTYException("Unsupported attributes") |
benchkit/communication/__init__.py
Outdated
| return list_hosts | ||
|
|
||
|
|
||
| class StatusAware(ABC): |
Collaborator
There was a problem hiding this comment.
is that class necessary?
Contributor
Author
There was a problem hiding this comment.
its a way to have stronger guarantees on a comm status. Should I remove it and assume that init always open instead and, while the class is alive the comm is as well ?
Collaborator
There was a problem hiding this comment.
keep it but move it to pty.py for now. Also please document the different methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a pty comm layer and a status aware abstract class