Refactor RecurringConfig from struct to struct interface#179
Merged
jordanschalm merged 2 commits intomainfrom Feb 23, 2026
Merged
Refactor RecurringConfig from struct to struct interface#179jordanschalm merged 2 commits intomainfrom
jordanschalm merged 2 commits intomainfrom
Conversation
Convert RecurringConfig to a struct interface with getter functions and introduce RecurringConfigImplv1 as the concrete implementation. This enables future alternative implementations of the config interface. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
holyfuchs
approved these changes
Feb 23, 2026
Contributor
holyfuchs
left a comment
holyfuchs
left a comment
There was a problem hiding this comment.
The Config was mostly copied from FlowActions:
https://github.com/onflow/FlowActions/blob/2357ae770e6c5cccae65e2965f75b4fba0a64ed9/cadence/contracts/interfaces/DeFiActions.cdc#L634
We might want to change it there as well.
joshuahannan
approved these changes
Feb 23, 2026
Member
Author
Do you know what that version of the Autobalancer is used for? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert RecurringConfig to a struct interface with getter functions and introduce RecurringConfigImplv1 as the concrete implementation. This enables future alternative implementations of the config interface, using the pattern here.